Message-ID: <1389063069.3040.90.camel@empanada>
Subject: Re: [PATCH 0/2] tracing/triggers: A couple minor variable name
 changes
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org
Date: Mon, 06 Jan 2014 20:51:09 -0600
In-Reply-To: <20140106205034.53c219cc@gandalf.local.home>
References: <cover.1389036657.git.tom.zanussi@linux.intel.com>
	 <20140106161347.4cc82a4b@gandalf.local.home>
	 <1389055673.3040.83.camel@empanada>
	 <20140106205034.53c219cc@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

> 
> > > +	enum event_trigger_type tt = ETT_NONE;
> > > +
> > > +	if (__event_trigger_test_discard(file, buffer, event, entry, &tt))
> > > +		trace_buffer_unlock_commit(buffer, event, irq_flags, pc);
> > 
> > The logic is correct overall, but the way it reads is the opposite of
> > what it used to i.e. it should read 'if you don't discard the event,
> > then do the trace_buffer_unlock_commit' - it works as written because it
> > returns 1 if it didn't discard, which is confusing.
> 
> Hmm, OK, I think you may have convinced me. I'll swap the return values.
> 

Sounds great, thanks!

> I need to write up some trigger tests to make sure they work the same
> before and after this patch.
> 

I'll run the next version through my 'testsuite', which unfortunately is
still manual (one of the many things on my todo list is automate it)..

Tom


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/