Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbaAGKwG (ORCPT ); Tue, 7 Jan 2014 05:52:06 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:44258 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbaAGKwE convert rfc822-to-8bit (ORCPT ); Tue, 7 Jan 2014 05:52:04 -0500 X-Originating-IP: 50.43.14.201 Date: Tue, 7 Jan 2014 02:51:54 -0800 From: Josh Triplett To: Jakob Bornecrantz Cc: Rashika Kheria , Linux Kernel Mailing List , Daniel Vetter , DRI Development , Dave Airlie , Rob Clark Subject: Re: [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c Message-ID: <20140107105154.GC4891@leaf> References: <477dcfde0b9247c91030dedcbf71af7dafdb7bf4.1389018325.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote: > On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria wrote: > > Mark functions as static because they are not used outside the file > > drm/vmwgfx/vmwgfx_kms.c. > > > > This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c: > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for ‘vmw_clip_cliprects’ [-Wmissing-prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for ‘vmw_framebuffer_surface_destroy’ [-Wmissing-prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for ‘vmw_framebuffer_surface_dirty’ [-Wmissing-prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_destroy’ [-Wmissing-prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_dirty’ [-Wmissing-prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype for ‘vmw_du_update_layout’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > This and patch 83, 84, 85 are > Reviewed-by: Jakob Bornecrantz Can you take them through your tree, or are you expecting them to follow another path? - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/