Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251AbaAGLtJ (ORCPT ); Tue, 7 Jan 2014 06:49:09 -0500 Received: from mail.fireflyinternet.com ([87.106.93.118]:50502 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750892AbaAGLtD (ORCPT ); Tue, 7 Jan 2014 06:49:03 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.73.22; Date: Tue, 7 Jan 2014 11:48:54 +0000 From: Chris Wilson To: Ramkumar Ramachandra Cc: LKML , Andreas Heider , Seth Forshee Subject: Re: [PATCH 4/4] drm/i915: check LVDS for EDID on GPU switches Message-ID: <20140107114854.GE8991@nuc-i3427.alporthouse.com> References: <1389088723-30959-1-git-send-email-artagnon@gmail.com> <1389088723-30959-5-git-send-email-artagnon@gmail.com> <20140107104553.GC8991@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2014 at 04:42:12PM +0530, Ramkumar Ramachandra wrote: > Chris Wilson wrote: > > On Tue, Jan 07, 2014 at 03:28:43PM +0530, Ramkumar Ramachandra wrote: > >> If the LVDS panel wasn't connected at boot then we won't have an EDID > >> for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo > >> reprobe callback. > > > > I would rather have an iterator over all our connectors (or perhaps > > encoders would be the right semantic, except we have > > connectors==encoders) and a reprobe callback. > > I don't follow; iterate over which connectors? There's one > lvds_connector for which we get EDID. Rather than special casing lvds (especially when there are other panel connectors that can also be muxed), extend the connector interface to support a reprobe and walk over all connectors associated with i915 after a switcheroo event. > > Saves exporting private > > functions and prevent me asking silly questions like what about eDP? > > Avoid exporting intel_lvds_get_edid()? Why? Because it's a special case and misses others. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/