Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751517AbaAGMqG (ORCPT ); Tue, 7 Jan 2014 07:46:06 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:59085 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbaAGMqD (ORCPT ); Tue, 7 Jan 2014 07:46:03 -0500 From: Eduardo Valentin To: CC: , Eduardo Valentin , Jean Delvare , Guenter Roeck , , Subject: [PATCH 1/1] thermal: fix compilation issue on CONFIG_THERMAL_OF dependencies Date: Tue, 7 Jan 2014 08:44:27 -0400 Message-ID: <1389098667-9826-1-git-send-email-eduardo.valentin@ti.com> X-Mailer: git-send-email 1.8.2.1.342.gfa7285d In-Reply-To: <52CBF1CF.2000603@ti.com> References: <52CBF1CF.2000603@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Users of API provided by THERMAL_OF config may suffer when CONFIG_THERMAL=y, causing linking issues, such as: drivers/built-in.o: In function `lm75_remove': lm75.c:(.text+0x12bd8c): undefined reference to `thermal_zone_of_sensor_unregister' drivers/built-in.o: In function `lm75_probe': lm75.c:(.text+0x12c123): undefined reference to `thermal_zone_of_sensor_register' Therefore, this patch limits the compilation build to always have THERMAL=y, whenever THERMAL_OF=y. In this way, whenever the API user is built, if THERMAL_OF=y, the build shall have the full thermal support, otherwise, the thermal API will provide stubs. Cc: Zhang Rui Cc: Jean Delvare Cc: Guenter Roeck Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Reported-by: Randy Dunlap Signed-off-by: Eduardo Valentin --- drivers/thermal/Kconfig | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 58f98bd..dc315e9 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -29,19 +29,6 @@ config THERMAL_HWMON Say 'Y' here if you want all thermal sensors to have hwmon sysfs interface too. -config THERMAL_OF - bool - prompt "APIs to parse thermal data out of device tree" - depends on OF - default y - help - This options provides helpers to add the support to - read and parse thermal data definitions out of the - device tree blob. - - Say 'Y' here if you need to build thermal infrastructure - based on device tree. - choice prompt "Default Thermal governor" default THERMAL_DEFAULT_GOV_STEP_WISE @@ -235,3 +222,19 @@ source "drivers/thermal/samsung/Kconfig" endmenu endif + +menuconfig THERMAL_OF + bool + prompt "APIs to parse thermal data out of device tree" + depends on OF + select THERMAL + default y + help + This options enables DT thermal API which adds support to + read and parse thermal data definitions out of the + device tree blob. This option is mostly used by embedded + thermal drivers. + + Say 'Y' here if you need to build thermal infrastructure + based on device tree. + -- 1.8.2.1.342.gfa7285d -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/