Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753480AbaAGRnk (ORCPT ); Tue, 7 Jan 2014 12:43:40 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:59264 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388AbaAGRnb convert rfc822-to-8bit (ORCPT ); Tue, 7 Jan 2014 12:43:31 -0500 MIME-Version: 1.0 In-Reply-To: References: <1388394595-1347-1-git-send-email-tushar.behera@linaro.org> <1388726757-7387-1-git-send-email-tushar.behera@linaro.org> From: Bryan Wu Date: Tue, 7 Jan 2014 09:43:09 -0800 Message-ID: Subject: Re: [PATCH V2] leds: s3c24xx: Fix build failure To: Linus Walleij Cc: Tushar Behera , lkml , Linux LED Subsystem , "rpurdie@rpsys.net" Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 7, 2014 at 9:41 AM, Linus Walleij wrote: > On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu wrote: >> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera wrote: >>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom ") >>> removed the usage of mach/gpio.h file, but we need to include >>> plat/gpio-cfg.h to avoid following build error. >>> >>> Fixes following build error. >>> drivers/leds/leds-s3c24xx.c: In function ?s3c24xx_led_probe?: >>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of >>> function ?s3c_gpio_setpull? [-Werror=implicit-function-declaration] >>> >> >> I think this patch should go with Linus's patchset. > > Patch applied to the GPIO tree. I added your ACK Bryan since > that seems to be implied above ... > Sure, thanks. -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/