Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753691AbaAGSHE (ORCPT ); Tue, 7 Jan 2014 13:07:04 -0500 Received: from merlin.infradead.org ([205.233.59.134]:38123 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbaAGSG4 (ORCPT ); Tue, 7 Jan 2014 13:06:56 -0500 Message-ID: <52CC4237.5000704@infradead.org> Date: Tue, 07 Jan 2014 10:06:47 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Jean Delvare , Eduardo Valentin CC: Guenter Roeck , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Frodo Looijaard , lm-sensors@lm-sensors.org, Zhang Rui , linux-pm@vger.kernel.org Subject: Re: [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies References: <20140106204020.b47e53cc3ead8f90164ef5b7@canb.auug.org.au> <52CB0948.6030702@infradead.org> <20140106203209.GA21630@roeck-us.net> <52CB53DC.4030901@infradead.org> <52CB65DA.2010103@roeck-us.net> <20140107130401.23bffcd2@endymion.delvare> <52CBF1CF.2000603@ti.com> <20140107152148.36768345@endymion.delvare> In-Reply-To: <20140107152148.36768345@endymion.delvare> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/14 06:21, Jean Delvare wrote: > Hi Eduardo, > > I suppose this works, however I believe there is value in allowing for > modular building of as much code as possible. ack, yes, please. > I have an alternative proposal, which lets thermal be built as module, > and hopefully also addresses the issue (I can't test...) The only > drawback is that the same dependency must be added for every other > hwmon driver which optionally uses THERMAL_OF. > > From: Jean Delvare > > Based on an earlier attempt by Randy Dunlap. > > Fix SENSORS_LM75 dependencies to eliminate build errors: > > drivers/built-in.o: In function `lm75_remove': > lm75.c:(.text+0x12bd8c): undefined reference to `thermal_zone_of_sensor_unregister' > drivers/built-in.o: In function `lm75_probe': > lm75.c:(.text+0x12c123): undefined reference to `thermal_zone_of_sensor_register' > > Add depends on THERMAL since that is what provides the > register/unregister functions above, but only if THERMAL_OF was > selected as this is an optional feature of the driver. > > Signed-off-by: Jean Delvare > Cc: Randy Dunlap > Cc: Eduardo Valentin works for me. Acked-by: Randy Dunlap Thanks. > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-3.13-rc7.orig/drivers/hwmon/Kconfig 2014-01-07 09:01:24.812848091 +0100 > +++ linux-3.13-rc7/drivers/hwmon/Kconfig 2014-01-07 15:19:11.039472329 +0100 > @@ -650,6 +650,7 @@ config SENSORS_LM73 > config SENSORS_LM75 > tristate "National Semiconductor LM75 and compatibles" > depends on I2C > + depends on THERMAL || !THERMAL_OF > help > If you say yes here you get support for one common type of > temperature sensor chip, with models including: > > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/