Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756888AbaAHNuG (ORCPT ); Wed, 8 Jan 2014 08:50:06 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:43864 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755610AbaAHNuA (ORCPT ); Wed, 8 Jan 2014 08:50:00 -0500 X-IronPort-AV: E=Sophos;i="4.95,624,1384300800"; d="scan'208";a="88712747" Message-ID: <52CD5785.4050402@citrix.com> Date: Wed, 8 Jan 2014 13:49:57 +0000 From: Zoltan Kiss User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eric Dumazet CC: , , , , , Subject: Re: [PATCH net-next v3 6/9] xen-netback: Handle guests with too many frags References: <1389139818-24458-1-git-send-email-zoltan.kiss@citrix.com> <1389139818-24458-7-git-send-email-zoltan.kiss@citrix.com> <1389147141.26646.74.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1389147141.26646.74.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.2.133] X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/14 02:12, Eric Dumazet wrote: > On Wed, 2014-01-08 at 00:10 +0000, Zoltan Kiss wrote: > >> >> + if (skb_shinfo(skb)->frag_list) { >> + nskb = skb_shinfo(skb)->frag_list; >> + xenvif_fill_frags(vif, nskb, INVALID_PENDING_IDX); >> + skb->len += nskb->len; >> + skb->data_len += nskb->len; >> + skb->truesize += nskb->truesize; >> + skb_shinfo(skb)->tx_flags |= SKBTX_DEV_ZEROCOPY; >> + skb_shinfo(nskb)->tx_flags |= SKBTX_DEV_ZEROCOPY; >> + vif->tx_zerocopy_sent += 2; >> + nskb = skb; >> + >> + skb = skb_copy_expand(skb, >> + 0, >> + 0, >> + GFP_ATOMIC | __GFP_NOWARN); > > skb can be NULL here Thanks, fixed that. Zoli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/