Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbaAHQkb (ORCPT ); Wed, 8 Jan 2014 11:40:31 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:33848 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756765AbaAHQk3 convert rfc822-to-8bit (ORCPT ); Wed, 8 Jan 2014 11:40:29 -0500 MIME-Version: 1.0 In-Reply-To: <8af55c93ab10b11d473f9c731eddd6710ae7a418.1389018324.git.rashika.kheria@gmail.com> References: <8af55c93ab10b11d473f9c731eddd6710ae7a418.1389018324.git.rashika.kheria@gmail.com> Date: Wed, 8 Jan 2014 11:40:28 -0500 Message-ID: Subject: Re: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c From: Alex Deucher To: Rashika Kheria Cc: LKML , Josh Triplett , Maling list - DRI developers , Jerome Glisse , Alex Deucher , Dave Airlie , =?ISO-8859-1?Q?Christian_K=F6nig?= Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria wrote: > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as > static in drm/radeon/radeon_device.c because they are not used outside > this file. > > This eliminates the following warning in drm/radeon/radeon_device.c: > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous prototype for ?radeon_doorbell_init? [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous prototype for ?radeon_doorbell_fini? [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett I've pulled in a subset of these patches: http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.14-wip I held off on some of the others as I'd rather fix up the headers properly rather than just cramming everything in radeon.h or radeon-asic.h for now. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c > index 39b033b..caf4975 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -249,7 +249,7 @@ void radeon_scratch_free(struct radeon_device *rdev, uint32_t reg) > * Init doorbell driver information (CIK) > * Returns 0 on success, error on failure. > */ > -int radeon_doorbell_init(struct radeon_device *rdev) > +static int radeon_doorbell_init(struct radeon_device *rdev) > { > /* doorbell bar mapping */ > rdev->doorbell.base = pci_resource_start(rdev->pdev, 2); > @@ -278,7 +278,7 @@ int radeon_doorbell_init(struct radeon_device *rdev) > * > * Tear down doorbell driver information (CIK) > */ > -void radeon_doorbell_fini(struct radeon_device *rdev) > +static void radeon_doorbell_fini(struct radeon_device *rdev) > { > iounmap(rdev->doorbell.ptr); > rdev->doorbell.ptr = NULL; > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/