Message-ID: <1389211514.14754.10.camel@x220>
Subject: Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime
 error
From: Paul Bolle <pebolle@tiscali.nl>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 08 Jan 2014 21:05:14 +0100
In-Reply-To: <1359454842.1345.40.camel@x61.thuisdomein>
References: <1352113082.1434.31.camel@x61.thuisdomein>
	 <1359454842.1345.40.camel@x61.thuisdomein>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
> On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> > Building advansys.o triggers this warning:
> >     drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]
> > 
> > This warning can be traced back to a patch called "advansys: add warning
> > and convert #includes" which was included in v2.6.10. That patch also
> > marked the driver as BROKEN.
> > 
> > Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
> > driver: limp along on x86") enabled this driver for x86-32. And commit
> > 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
> > work on parisc") enabled this driver for all architectures. But the
> > commit explanation stated:
> >     I haven't removed the #warning yet because virt_to_bus/bus_to_virt are
> >     only eliminated for narrow boards.  Wide boards need more work.
> > 
> > Five years have passed and, apparently, those wide boards still need
> > more work. So let's change the buildtime warning into a runtime error,
> > only printed for those wide boards. Perhaps that might push the people
> > using those wide boards to convert this driver. And for all others
> > there's now one less buildtime warning to ignore.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Compile tested only. I don't have any AdvanSys SCSI boards (neither
> > narrow nor wide).
> 
> The date of this message suggests I submitted this patch for a warning
> seen while building v3.7-rc4. An identical warning can be seen while
> building v3.8-rc5. What's the status of my patch? Did anyone find some
> time to have a look at it?

I've been carrying this patch locally for over a year. Is there any
chance of someone trying to remove this buildtime warning?

I'm inclined to submit a path to Fedora - my local builds use
their .config as a base - to just disable this driver. It seems that
would increase my chances of finally shutting down this warning.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/