Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757396AbaAHVQP (ORCPT ); Wed, 8 Jan 2014 16:16:15 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:47726 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbaAHVQM (ORCPT ); Wed, 8 Jan 2014 16:16:12 -0500 Date: Wed, 8 Jan 2014 14:16:10 -0700 From: Jason Gunthorpe To: Rob Herring Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH] dt: Document a compatible entry for MDIO ethernet Phys Message-ID: <20140108211610.GC12358@obsidianresearch.com> References: <20131210193947.GU5429@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.161 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2014 at 12:37:03PM -0600, Rob Herring wrote: > > Patch to parse this compatible string to follow if this binding is > > acceptable. > > One minor comment below, otherwise: > > Acked-by: Rob Herring K, I'll send a series hopefully in a few weeks after some travel. > > + If the phy's identifier is known then the list may contain an entry > > + of the form: "ethernet-phy-idAAAA,BBBB" where > > I think this should be a period rather than a comma as we are not > separating a vendor ID from product ID. OK, that makes sense. Inspecting further, the format of the 32 bit AAAABBBB is actually broken out into: OUI[3:18] || OUI[19:24] || MODEL[5:0] || REV[3:0] So a possible choice with the 'vendor ID,product ID' split is: ethernet-phyOOOOO,MM.R xlate is: AAAABBBB = ((OOOOO >> 6) << 16) | ((OOOOO & 0x3f) << 10) | (MM << 4) | R Which doesn't textually match the register value, or any other phy ID constants in the kernel, however makes more sense from the 'vendor ID,product ID' angle. Eg a Marvell 88E1310 would encode into the two options as: ethernet-phy05043,29.0 ethernet-phy-id0141.0e90 And the kernel has constants like this: include/linux/marvell_phy.h:#define MARVELL_PHY_ID_88E1318S 0x01410e90 In light of this detail do you still like 'ethernet-phy-id0141.0e90' ? Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/