Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757642AbaAIAHt (ORCPT ); Wed, 8 Jan 2014 19:07:49 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48246 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757266AbaAIAHq convert rfc822-to-8bit (ORCPT ); Wed, 8 Jan 2014 19:07:46 -0500 X-Originating-IP: 50.43.14.201 Date: Wed, 8 Jan 2014 16:07:35 -0800 From: Josh Triplett To: Alex Deucher Cc: Rashika Kheria , LKML , Maling list - DRI developers , Jerome Glisse , Alex Deucher , Dave Airlie , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c Message-ID: <20140109000735.GA23891@leaf> References: <8af55c93ab10b11d473f9c731eddd6710ae7a418.1389018324.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2014 at 11:40:28AM -0500, Alex Deucher wrote: > On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria > wrote: > > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as > > static in drm/radeon/radeon_device.c because they are not used outside > > this file. > > > > This eliminates the following warning in drm/radeon/radeon_device.c: > > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous prototype for ‘radeon_doorbell_init’ [-Wmissing-prototypes] > > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous prototype for ‘radeon_doorbell_fini’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > I've pulled in a subset of these patches: > http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.14-wip > I held off on some of the others as I'd rather fix up the headers > properly rather than just cramming everything in radeon.h or > radeon-asic.h for now. Can you elaborate on which patches are putting functions in the wrong header, and what header you'd prefer to see them in? - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/