Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754293AbaAIHFE (ORCPT ); Thu, 9 Jan 2014 02:05:04 -0500 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:43856 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbaAIHEd (ORCPT ); Thu, 9 Jan 2014 02:04:33 -0500 X-AuditID: 9c930197-b7b37ae000002e5a-ca-52ce49fe07e5 From: Joonsoo Kim To: Andrew Morton Cc: "Kirill A. Shutemov" , Rik van Riel , Jiang Liu , Mel Gorman , Cody P Schafer , Johannes Weiner , Michal Hocko , Minchan Kim , Michal Nazarewicz , Andi Kleen , Wei Yongjun , Tang Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Joonsoo Kim Subject: [PATCH 4/7] mm/isolation: remove invalid check condition Date: Thu, 9 Jan 2014 16:04:44 +0900 Message-Id: <1389251087-10224-5-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1389251087-10224-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1389251087-10224-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org test_page_isolated() checks stability of pages. It checks two conditions, one is that the page is on isolate migratetype and the other is that the page is on the buddy and the isolate freelist. With satisfying these two conditions, we can determine that the page is stable and then go forward. __test_page_isolated_in_pageblock() is one of the main functions for this test. In that function, if it meets the page with page_count 0 and isolate migratetype, it decides that this page is stable. But this is not true, because there is possiblity that this kind of page is on the pcp and then it can be allocated by other users even though we hold the zone lock. So removing this check. Signed-off-by: Joonsoo Kim diff --git a/mm/page_isolation.c b/mm/page_isolation.c index d1473b2..534fb3a 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -199,9 +199,6 @@ __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn, } pfn += 1 << page_order(page); } - else if (page_count(page) == 0 && - get_freepage_migratetype(page) == MIGRATE_ISOLATE) - pfn += 1; else if (skip_hwpoisoned_pages && PageHWPoison(page)) { /* * The HWPoisoned page may be not in buddy -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/