Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754908AbaAIIip (ORCPT ); Thu, 9 Jan 2014 03:38:45 -0500 Received: from mail-qc0-f175.google.com ([209.85.216.175]:46241 "EHLO mail-qc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbaAIIig (ORCPT ); Thu, 9 Jan 2014 03:38:36 -0500 MIME-Version: 1.0 X-Originating-IP: [173.13.129.225] In-Reply-To: References: Date: Thu, 9 Jan 2014 00:38:35 -0800 Message-ID: Subject: Re: [PATCH V3 Resend] cpufreq: create cpufreq_generic_get() routine From: Olof Johansson To: Viresh Kumar Cc: "Rafael J. Wysocki" , "linaro-kernel@lists.linaro.org" , Patch Tracking , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, On Mon, Jan 6, 2014 at 5:54 PM, Viresh Kumar wrote: > CPUFreq drivers that use clock frameworks interface,i.e. clk_get_rate(), to get > CPUs clk rate, has similar sort of code used for most of them. > > This patch adds a generic ->get() which will do the same thing for them. All > those drivers are required to now is to set .get to cpufreq_generic_get() and > set their clk pointer in policy->clk during ->init(). > > Acked-by: Hans-Christian Egtvedt > Acked-by: Shawn Guo > Acked-by: Linus Walleij > Acked-by: Shawn Guo > Acked-by: Stephen Warren > Signed-off-by: Viresh Kumar > --- > Rafael, > > V2->V3: As asked by you earlier, I have merged all 23 patches here as they had > common log and were touching separate drivers. This is already acked by many > people. Please see if looks okay for 3.14. This patch breaks a bunch of ARM boards. In particular, the following defconfigs no longer build: assabet_defconfig badge4_defconfig cerfcube_defconfig collie_defconfig h3600_defconfig hackkit_defconfig jornada720_defconfig lart_defconfig neponset_defconfig pleb_defconfig shannon_defconfig simpad_defconfig Error is: drivers/built-in.o: In function `cpufreq_generic_get': drivers/cpufreq/cpufreq.c:189: undefined reference to `clk_get_rate' Seems like this needs to be guarded by HAVE_CLK? -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/