Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757428AbaAIJ0h (ORCPT ); Thu, 9 Jan 2014 04:26:37 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:56414 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755097AbaAIJ03 (ORCPT ); Thu, 9 Jan 2014 04:26:29 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 9 Jan 2014 14:56:28 +0530 Message-ID: Subject: Re: [PATCH V3 Resend] cpufreq: create cpufreq_generic_get() routine From: Viresh Kumar To: Olof Johansson , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Fengguang Wu Cc: "Rafael J. Wysocki" , "linaro-kernel@lists.linaro.org" , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cc'ng Russell/LAKML/Fengguang.. On 9 January 2014 14:08, Olof Johansson wrote: > This patch breaks a bunch of ARM boards. In particular, the following > defconfigs no longer build: That's really bad, Rafael will scold me again :) > assabet_defconfig > badge4_defconfig > cerfcube_defconfig > collie_defconfig > h3600_defconfig > hackkit_defconfig > jornada720_defconfig > lart_defconfig > neponset_defconfig > pleb_defconfig > shannon_defconfig > simpad_defconfig > > Error is: > > drivers/built-in.o: In function `cpufreq_generic_get': > drivers/cpufreq/cpufreq.c:189: undefined reference to `clk_get_rate' > > Seems like this needs to be guarded by HAVE_CLK? Naah.. After some investigation I found this: - We already have dummy implementations of clk routines in case CONFIG_HAVE_CLK is not defined (I added them long back). - There is one thing common among all above defconfigs, all belong to SA1100 family :) - And the problem is: SA1100 wanted to define its own clk routines and selects CLKDEV_LOOKUP (which enables HAVE_CLK), but it doesn't implement all clk routines. Which is *wrong*. So, actually this patch brought an _existing_ bug in limelight. And this should be fixed by adding dummy or meaningful implementation of missing clk routines. @Russell: If above looks correct then can you please communicate what should we do here? I don't really know what exactly these routines should have, simply a copy of dummy routines from clk.h or some meaningful stuff. So, maybe you can write a patch, otherwise let me know what to write and I will give it a try. @Rafael: Please *don't* revert this patch, its not my fault this time :) @Fengguang: Would it make sense to add build tests for all ARM defconfigs in your build system? I thought its already there :) That way I can always be sure that my stuff (would be helpful for others as well though) isn't breaking build (Atleast) for any platform. Thanks. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/