From: Pali =?utf-8?q?Roh=C3=A1r?= <pali.rohar@gmail.com>
To: balbi@ti.com
Subject: Re: BUG: usb: obex in g_nokia.ko causing kernel panic
Date: Thu, 9 Jan 2014 15:17:36 +0100
User-Agent: KMail/1.13.7 (Linux/3.12.0-5-generic; KDE/4.12.0; x86_64; ; )
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pavel Machek <pavel@ucw.cz>, Aaro Koskinen <aaro.koskinen@iki.fi>,
        freemangordon@abv.bg, Sebastian Reichel <sre@ring0.de>
References: <201311191151.17153@pali> <201311271740.42913@pali> <20131127173904.GD8123@saruman.home>
In-Reply-To: <20131127173904.GD8123@saruman.home>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart2590290.h3bVG3HnNp";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201401091517.36357@pali>
Sender: linux-kernel-owner@vger.kernel.org

--nextPart2590290.h3bVG3HnNp
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wednesday 27 November 2013 18:39:04 Felipe Balbi wrote:
> Hi,
>=20
> On Wed, Nov 27, 2013 at 05:40:42PM +0100, Pali Roh=C3=A1r wrote:
> > > > > > @@ -282,10 +284,12 @@ static void
> > > > > > obex_disconnect(struct gserial *g) if
> > > > > > (!obex->can_activate)
> > > > > >=20
> > > > > >  		return;
> > > > > >=20
> > > > > > +#if 0
> > > > > >=20
> > > > > >  	status =3D usb_function_deactivate(&g->func);
> > > > > >  	if (status)
> > > > > >  =09
> > > > > >  		DBG(cdev, "obex ttyGS%d function deactivate -->
> > > > > >  		%d\n",
> > > > > >  	=09
> > > > > >  			obex->port_num, status);
> > > > > >=20
> > > > > > +#endif
> > > > > >=20
> > > > > >  }
> > > > > > =20
> > > > > >  /*-------------------------------------------------
> > > > > >  ---- ------
> > > > > >=20
> > > > > > --------------*/ @@ -372,6 +376,7 @@ static int
> > > > > > obex_bind(struct usb_configuration *c, struct
> > > > > > usb_function *f) if (status)
> > > > > >=20
> > > > > >  		goto fail;
> > > > > >=20
> > > > > > +#if 0
> > > > > >=20
> > > > > >  	/* Avoid letting this gadget enumerate until the
> > > > > >  	userspace
> > > > > >  =09
> > > > > >  	 * OBEX server is active.
> > > > > >  	 */
> > > > > >=20
> > > > > > @@ -381,6 +386,7 @@ static int obex_bind(struct
> > > > > > usb_configuration *c, struct usb_function *f)
> > > > > > obex->port_num, status);
> > > > > >=20
> > > > > >  	else
> > > > > >  =09
> > > > > >  		obex->can_activate =3D true;
> > > > > >=20
> > > > > > +#endif
> > > > > >=20
> > > > > >  	DBG(cdev, "obex ttyGS%d: %s speed IN/%s OUT/%s\n",
> > > > >=20
> > > > > Hi, with above patch g_nokia.ko working and not
> > > > > crashing.
> > > >=20
> > > > yeah, makes sense. We shouldn't call phy operations in
> > > > atomic context. I'll see how easy it would be to fix
> > > > that. Real patch coming soon(-ish).
> > >=20
> > > I think we could send diff below for the -rc cycle and
> > > figure out a better to handle this for the merge window.
> > > Can you check if it also works with patch below ?
> > >=20
> > > diff --git a/drivers/usb/musb/omap2430.c
> > > b/drivers/usb/musb/omap2430.c index 2a408cd..8aa59a2
> > > 100644 --- a/drivers/usb/musb/omap2430.c
> > > +++ b/drivers/usb/musb/omap2430.c
> > > @@ -659,7 +659,6 @@ static int
> > > omap2430_runtime_suspend(struct device *dev)
> > > OTG_INTERFSEL);
> > >=20
> > >  		omap2430_low_level_exit(musb);
> > >=20
> > > -		phy_power_off(musb->phy);
> > >=20
> > >  	}
> > >  =09
> > >  	return 0;
> > >=20
> > > @@ -674,7 +673,6 @@ static int
> > > omap2430_runtime_resume(struct device *dev)
> > > omap2430_low_level_init(musb);
> > >=20
> > >  		musb_writel(musb->mregs, OTG_INTERFSEL,
> > >  	=09
> > >  				musb->context.otg_interfsel);
> > >=20
> > > -		phy_power_on(musb->phy);
> > >=20
> > >  	}
> > >  =09
> > >  	return 0;
> >=20
> > Hi, I applied similar patch (commented usb_phy_set_suspend
> > instead phy_power_on/off) on 3.12-rc5 and it working too, no
> > crash. I do not have rebased n900 patches on top of 3.13
> > tree, so I cannot check it. But I think phy_power_on/off
> > doing same as usb_phy_set_suspend in 3.12.
>=20
> cool, I'll send this during the -rc and Cc stable, then I'll
> manually backport it to stable later.

PING!

I still do not see this patch in linus tree. What happened?

=2D-=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--nextPart2590290.h3bVG3HnNp
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAlLOr4AACgkQi/DJPQPkQ1Ji1ACgiqPu8NwVQXojqFTPHnfERobS
cJIAoIR8AdFYkHxOMLaldjdEyJqMuWaJ
=+7qG
-----END PGP SIGNATURE-----

--nextPart2590290.h3bVG3HnNp--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/