Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbaAIOfo (ORCPT ); Thu, 9 Jan 2014 09:35:44 -0500 Received: from mail-vb0-f44.google.com ([209.85.212.44]:40976 "EHLO mail-vb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbaAIOfS convert rfc822-to-8bit (ORCPT ); Thu, 9 Jan 2014 09:35:18 -0500 MIME-Version: 1.0 In-Reply-To: <20140109000735.GA23891@leaf> References: <8af55c93ab10b11d473f9c731eddd6710ae7a418.1389018324.git.rashika.kheria@gmail.com> <20140109000735.GA23891@leaf> Date: Thu, 9 Jan 2014 09:35:15 -0500 Message-ID: Subject: Re: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c From: Alex Deucher To: Josh Triplett Cc: Rashika Kheria , LKML , Maling list - DRI developers , Jerome Glisse , Alex Deucher , Dave Airlie , =?ISO-8859-1?Q?Christian_K=F6nig?= Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 8, 2014 at 7:07 PM, Josh Triplett wrote: > On Wed, Jan 08, 2014 at 11:40:28AM -0500, Alex Deucher wrote: >> On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria >> wrote: >> > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as >> > static in drm/radeon/radeon_device.c because they are not used outside >> > this file. >> > >> > This eliminates the following warning in drm/radeon/radeon_device.c: >> > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous prototype for ?radeon_doorbell_init? [-Wmissing-prototypes] >> > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous prototype for ?radeon_doorbell_fini? [-Wmissing-prototypes] >> > >> > Signed-off-by: Rashika Kheria >> > Reviewed-by: Josh Triplett >> >> I've pulled in a subset of these patches: >> http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.14-wip >> I held off on some of the others as I'd rather fix up the headers >> properly rather than just cramming everything in radeon.h or >> radeon-asic.h for now. > > Can you elaborate on which patches are putting functions in the wrong > header, and what header you'd prefer to see them in? Sure. atombios.h defines the vbios interface so it shouldn't have any driver functions defined in it. radeon_asic.h was only supposed to include the function definitions for the asic specific callbacks assigned in radeon_asic.c. For everything else, I'd rather move to asic specific headers, e.g., rather than adding r600_*() functions to radeon.h for example, I'd rather add an r600.h and include that where r600_*() functions are used, etc. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/