Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754027AbaAIPtx (ORCPT ); Thu, 9 Jan 2014 10:49:53 -0500 Received: from smtp.citrix.com ([66.165.176.89]:57564 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbaAIPtr (ORCPT ); Thu, 9 Jan 2014 10:49:47 -0500 X-IronPort-AV: E=Sophos;i="4.95,631,1384300800"; d="scan'208";a="91325783" Message-ID: <52CEC518.60606@citrix.com> Date: Thu, 9 Jan 2014 16:49:44 +0100 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Wei Liu , Zoltan Kiss CC: , , , , , David Vrabel , Subject: Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions References: <1389139818-24458-1-git-send-email-zoltan.kiss@citrix.com> <1389139818-24458-2-git-send-email-zoltan.kiss@citrix.com> <20140109153010.GE12164@zion.uk.xensource.com> In-Reply-To: <20140109153010.GE12164@zion.uk.xensource.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/14 16:30, Wei Liu wrote: > On Wed, Jan 08, 2014 at 12:10:10AM +0000, Zoltan Kiss wrote: >> This patch contains the new definitions necessary for grant mapping. >> >> v2: >> - move unmapping to separate thread. The NAPI instance has to be scheduled >> even from thread context, which can cause huge delays >> - that causes unfortunately bigger struct xenvif >> - store grant handle after checking validity >> >> v3: >> - fix comment in xenvif_tx_dealloc_action() >> - call unmap hypercall directly instead of gnttab_unmap_refs(), which does >> unnecessary m2p_override. Also remove pages_to_[un]map members > > Is it worthy to have another function call > gnttab_unmap_refs_no_m2p_override in Xen core driver, or just add a > parameter to control wether we need to touch m2p_override? I *think* it > will benefit block driver as well? Anthony Liguori posted a patch to perform something similar in blkback, but I think the patch never made it upstream: https://lkml.org/lkml/2013/11/12/749 Probably a good time to revisit it so this mechanism can be used by both blkback and netback? Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/