From: KY Srinivasan <kys@microsoft.com>
To: Olaf Hering <olaf@aepfle.de>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "apw@canonical.com" <apw@canonical.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH 1/1] Drivers: hv: Implement the file copy service
Thread-Topic: [PATCH 1/1] Drivers: hv: Implement the file copy service
Thread-Index: AQHPDMVZ9zrtMOoYp0KOm7oSIbZbR5p8TC2AgABjvCA=
Date: Thu, 9 Jan 2014 18:01:21 +0000
Message-ID: <35fb9cd2070242f1b1f5f5c44e6d1438@BY2PR03MB299.namprd03.prod.outlook.com>
References: <1389224915-8737-1-git-send-email-kys@microsoft.com>
 <20140109120351.GA25423@aepfle.de>
In-Reply-To: <20140109120351.GA25423@aepfle.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit


> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Thursday, January 09, 2014 4:04 AM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service
> 
> On Wed, Jan 08, K. Y. Srinivasan wrote:
> 
> > +++ b/tools/hv/hv_fcopy_daemon.c
> 
> > +		len = pread(fcopy_fd, buffer, (4096 * 2), 0);
> > +
> > +		if (len <= 0) {
> > +			syslog(LOG_ERR, "Read error: %s\n", strerror(errno));
> > +			continue;
> 
> This could flood syslog. I think the error should be logged just once.
> Maybe like this:
> 
>         if (len <=0) {
>                 if (!error) {
>                         syslog(...);
>                         error = HV_ERROR_NOT_SUPPORTED;
>                 }
>                 continue;
>         }
> 
> > +		}
> > +		in_msg = (struct hv_fcopy_hdr *)buffer;
> > +
> > +		switch (in_msg->operation) {
> > +		case START_FILE_COPY:
> > +			error = hv_start_fcopy((struct hv_start_fcopy *)in_msg);

Will do. 

K. Y
> 
> Olaf
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?