Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756446AbaAJAci (ORCPT ); Thu, 9 Jan 2014 19:32:38 -0500 Received: from ring0.de ([91.143.88.219]:42279 "EHLO smtp.ring0.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbaAJAce (ORCPT ); Thu, 9 Jan 2014 19:32:34 -0500 X-Spam-Report: * -0.0 NO_RELAYS Informational: message was not relayed via SMTP * -1.9 BAYES_00 BODY: Spamwahrscheinlichkeit nach Bayes-Test: 0-1% * [score: 0.0000] * -0.0 NO_RECEIVED Informational: message has no Received headers Date: Fri, 10 Jan 2014 01:32:31 +0100 From: Sebastian Reichel To: Pavel Machek Cc: Marcel Holtmann , Pali =?iso-8859-1?Q?Roh=E1r?= , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , "Gustavo F. Padovan" , Johan Hedberg , linux-kernel , "linux-bluetooth@vger.kernel.org development" , Ville Tervo Subject: Re: [PATCH v4] Bluetooth: Add hci_h4p driver Message-ID: <20140110003231.GA14141@earth.universe> Mail-Followup-To: Pavel Machek , Marcel Holtmann , Pali =?iso-8859-1?Q?Roh=E1r?= , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , "Gustavo F. Padovan" , Johan Hedberg , linux-kernel , "linux-bluetooth@vger.kernel.org development" , Ville Tervo References: <1379703710-5757-1-git-send-email-pali.rohar@gmail.com> <1727897.LBX8128hIo@izba> <20140102161824.GA8204@amd.pavel.ucw.cz> <20140103001753.GA21023@amd.pavel.ucw.cz> <20140103013640.GB27678@earth.universe> <20140109233843.GB19974@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <20140109233843.GB19974@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Pavel, On Fri, Jan 10, 2014 at 12:38:43AM +0100, Pavel Machek wrote: > > Here are some cleanup suggestions for probe, removal & module > > initialization functions. >=20 > ...and here's the patch implementing those suggestions. Thanks! That looks right, but you forgot to cleanup hci_h4p_remove. Also I suggest to simply merge this as v5. -- Sebastian --gKMricLos+KVdGMg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBCAAGBQJSzz+eAAoJENju1/PIO/qa4FoP/Ayooh8mXhiIC/1ZmsEiw8qZ o9UV40lamiJINCzIErKqdjzoStPHBNGTO424WMPkpsrLrPDcpq0SCcnPnYsSrMR9 YFgfjVI7REeRrOdJx8N/XX9xRhFnHuZ4RcfdhUa+oUXJ/QvBtC6ml6zuI1gOy8f4 DADhpAGB9mdubVNDBcfiCEiiS3J6NWbroSsZakcgdEC98u40Hu5OK5sCyr2FZwtb LJeAIZe0jRQA3crP0E/2UKtfAKhfgvvaMhgSAKfM2TuH0dfKe79Fyo8KFBGQZxtz aOVgKzzeZ6+dVg1Tt3unvISHEBJcN0iXne6v+t7baigS7blaa2xzX6MwGFpTaUew Pvc/Z0iNVlH5WOQS8HMbW8T3y1iOz192eXDF6Gic3b7SW09Uac6ZgTO2JnmnAndf nAkibtiYVOG2QPeKYmoBESDZXCLgufqImUuOCzWPES2oF2gQ2cnV0EU7VoueKdqo ScD3Vq3i6wzDz73qnNtPKT2h/CvbqKdsOjaJHpljm6LekquC498wjwJTJLrAM9z6 p4Jc2MYZ3YMtCwTS2/+4Pc7A4HVt7k3v1LXEOUjaHPYQOUu9JCXp/RlV3iSU6Tb0 d5/03R507La5Q4x0ZApzVWLVi6BNHAIzpluA9s/zXPX8JTcBx1pTiuyPNX7nROb8 qj9ah+pghf2LNclT04bk =8NWn -----END PGP SIGNATURE----- --gKMricLos+KVdGMg-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/