Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbaAJEHp (ORCPT ); Thu, 9 Jan 2014 23:07:45 -0500 Received: from mail-qe0-f46.google.com ([209.85.128.46]:47847 "EHLO mail-qe0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbaAJEHn (ORCPT ); Thu, 9 Jan 2014 23:07:43 -0500 Date: Thu, 9 Jan 2014 23:08:47 -0500 (EST) From: Vince Weaver To: Will Deacon cc: Chad Paradis , Peter Zijlstra , "linux-kernel@vger.kernel.org" , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Stephane Eranian Subject: Re: [patch/rfc] perf on raspberry-pi without overflow interrupt In-Reply-To: <20140109101921.GA26435@mudshark.cambridge.arm.com> Message-ID: References: <20140108225315.GG31570@twins.programming.kicks-ass.net> <20140109101921.GA26435@mudshark.cambridge.arm.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Jan 2014, Will Deacon wrote: > I'd rather see it in the generic code if at all possible. Maybe we could add > a flags field to perf_pmu_register? I can look into adding the check in generic code. In the meantime, would you consider a patch like this that disables the IRQ check and lets ARM devices missing an IRQ (such as the rasp-pi) still have access to the counters? diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c index d85055c..ff1a752 100644 --- a/arch/arm/kernel/perf_event_cpu.c +++ b/arch/arm/kernel/perf_event_cpu.c @@ -97,8 +97,8 @@ static int cpu_pmu_request_irq(struct arm_pmu *cpu_pmu, irq_handler_t handler) irqs = min(pmu_device->num_resources, num_possible_cpus()); if (irqs < 1) { - pr_err("no irqs for PMUs defined\n"); - return -ENODEV; + printk_once("no irqs for PMUs defined, sampling events not supported\n"); + return 0; } for (i = 0; i < irqs; ++i) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/