Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754138AbaAJGTz (ORCPT ); Fri, 10 Jan 2014 01:19:55 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:47843 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbaAJGTu (ORCPT ); Fri, 10 Jan 2014 01:19:50 -0500 Message-ID: <1389334891.5567.373.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16 From: "Nicholas A. Bellinger" To: Sagi Grimberg Cc: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , "Martin K. Petersen" , Christoph Hellwig , Hannes Reinecke , Or Gerlitz Date: Thu, 09 Jan 2014 22:21:31 -0800 In-Reply-To: <52CE78EB.60108@mellanox.com> References: <1389212157-14540-1-git-send-email-nab@daterainc.com> <1389212157-14540-8-git-send-email-nab@daterainc.com> <52CE78EB.60108@mellanox.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-01-09 at 12:24 +0200, Sagi Grimberg wrote: > On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch updates sbc_emulate_readcapacity_16() to set > > P_TYPE and PROT_EN bits when DIF emulation is enabled by > > the backend device. > > > > Cc: Martin K. Petersen > > Cc: Christoph Hellwig > > Cc: Hannes Reinecke > > Cc: Sagi Grimberg > > Cc: Or Gerlitz > > Signed-off-by: Nicholas Bellinger > > --- > > drivers/target/target_core_sbc.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c > > index 366b9bb..22599e8 100644 > > --- a/drivers/target/target_core_sbc.c > > +++ b/drivers/target/target_core_sbc.c > > @@ -106,6 +106,11 @@ sbc_emulate_readcapacity_16(struct se_cmd *cmd) > > buf[9] = (dev->dev_attrib.block_size >> 16) & 0xff; > > buf[10] = (dev->dev_attrib.block_size >> 8) & 0xff; > > buf[11] = dev->dev_attrib.block_size & 0xff; > > + /* > > + * Set P_TYPE and PROT_EN bits for DIF support > > + */ > > + if (dev->dev_attrib.pi_prot_type) > > + buf[12] = (dev->dev_attrib.pi_prot_type - 1) << 1 | 0x1; > > > > if (dev->transport->get_lbppbe) > > buf[13] = dev->transport->get_lbppbe(dev) & 0x0f; > > Hey Nic, > > What about FORMAT_UNIT emulation? Would certainly be useful to have.. > The backstore protection configuration is done at the target side via > configfs/targetcli, if you publish DIF support in > INQUERY_EVPD/READ_CAPACITY you need to accept protection information format? Mmmm, these two bits bits are following what scsi_debug is currently exposing minus FORMAT_UNIT support..? MKP..? --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/