Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756327AbaAJK3Q (ORCPT ); Fri, 10 Jan 2014 05:29:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20211 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbaAJK3N (ORCPT ); Fri, 10 Jan 2014 05:29:13 -0500 Date: Fri, 10 Jan 2014 18:27:46 +0800 From: Baoquan To: Yasuaki Ishimatsu Cc: Toshi Kani , Vivek Goyal , kexec@lists.infradead.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, tangchen@cn.fujitsu.com, linux-acpi@vger.kernel.org, zhangyanfei@cn.fujitsu.com, dyoung@redhat.com Subject: Re: kdump failed because of hotplug memory adding in kdump kernel Message-ID: <20140110102746.GC14074@dhcp-16-105.nay.redhat.com> References: <20140109162427.GF25897@redhat.com> <1389288265.1792.108.camel@misato.fc.hp.com> <20140109182310.GG25897@redhat.com> <1389292470.1792.109.camel@misato.fc.hp.com> <20140109212705.GC12111@redhat.com> <1389304583.1792.139.camel@misato.fc.hp.com> <20140110071124.GA6464@dhcp-16-105.nay.redhat.com> <52CFAA20.2010109@jp.fujitsu.com> <20140110091433.GA14074@dhcp-16-105.nay.redhat.com> <52CFBECB.9040309@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52CFBECB.9040309@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/14 at 06:35pm, Yasuaki Ishimatsu wrote: > (2014/01/10 18:14), Baoquan wrote: > > > > >In ns > >>>object tree, they are not treated as hotplug memory. > >> > >>wrong. > >>They are treated as hotplug memory. But the memory cannot hot removed > >>because the memory has kernel memory. > >> > >>>Otherwise, any hotplug memory which is not reserved for 2nd kernel can > >>>be parsed and need be added as hotplug memory, and add them into movable > >>>zone. > >> > >>wrong. > >>The memory is allocated as normal zone and it is offline. > > > >Hi, > > > >Thanks for answering. > > > > > >I am confused. Now the fact is in 1st kernel memory is reserved for > >crashkernel and passed to 2nd kernel by exactmap. Then in 2nd kernel, > >reserved memory regions are added into e820. Later hotplug memory still > >trigger add_memory, and cause bug I reported. > > Does the issue occur even if you apply the following Prarit's patch to > your kernel and add no_memory_hotplug boot option to 2nd kernel? > > http://marc.info/?l=linux-acpi&m=138922019607796&w=2 This issue is the same as Prarit's. He posted the formal patch. But still there are some questions we want to know. > > Thanks, > Yasuaki Ishimatsu > > > > > > >> > >>> > >>>Am I right? > >>> > >> > >>>The other question, e820 reserve is done earlier than acpi > >>>initialization, because acpi_early_init() invocation is very late in > >>>start_kernel(). Does that means at the very beginning all memorys are in > >>>e820, later when acpi_early_init is called, hotplug memory is detected, > >>>they will be moved to different place or need be marked with a specific > >>>flag? > >> > >>No. > >> > >>Thanks, > >>Yasuaki Ishimatsu > >> > > > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/