Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756084AbaAJKzi (ORCPT ); Fri, 10 Jan 2014 05:55:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42747 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbaAJKzf (ORCPT ); Fri, 10 Jan 2014 05:55:35 -0500 Date: Fri, 10 Jan 2014 11:55:33 +0100 Message-ID: From: Takashi Iwai To: Nenghua Cao Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , , Subject: Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param In-Reply-To: <1389332195-15900-1-git-send-email-nhcao@marvell.com> References: <1389332195-15900-1-git-send-email-nhcao@marvell.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Corrected mail addresses of both Mark and Liam] At Fri, 10 Jan 2014 13:36:35 +0800, Nenghua Cao wrote: > > From: Nenghua Cao > > It fixes the following case: > Two FEs connects the same BE; FE1 & BE path has been opened and hw_paramed. > At this momment, FE2 & BE path is being opened and hw_paramed. The BE > dai will do hw_param again even if it has done hw_param. It is not > reasonable. > FE1------------>BE > FE2-------------^ What happens if FE2 tries to set up an incompatible hw_params? (Through a quick glance, it won't work properly well, too, though...) Takashi > > Signed-off-by: Nenghua Cao > --- > sound/soc/soc-pcm.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > index 891b9a9..ec07e37 100644 > --- a/sound/soc/soc-pcm.c > +++ b/sound/soc/soc-pcm.c > @@ -1339,7 +1339,6 @@ static int dpcm_be_dai_hw_params(struct snd_soc_pcm_runtime *fe, int stream) > continue; > > if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_OPEN) && > - (be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_PARAMS) && > (be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_FREE)) > continue; > > -- > 1.7.0.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/