Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758154AbaAJUwi (ORCPT ); Fri, 10 Jan 2014 15:52:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758059AbaAJUwg (ORCPT ); Fri, 10 Jan 2014 15:52:36 -0500 Message-ID: <1389387122.2591.96.camel@deneb.redhat.com> Subject: Re: [PATCH v3 4/6] arm: add early_ioremap support From: Mark Salter To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Russell King , Arnd Bergmann , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Date: Fri, 10 Jan 2014 15:52:02 -0500 In-Reply-To: <52D05ABD.30904@codeaurora.org> References: <1389325833-16535-1-git-send-email-msalter@redhat.com> <1389325833-16535-5-git-send-email-msalter@redhat.com> <52D05ABD.30904@codeaurora.org> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-01-10 at 12:40 -0800, Stephen Boyd wrote: > Just some minor nitpicks > > On 01/09/14 19:50, Mark Salter wrote: > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index c1f1a7e..78a79a6a 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -1842,6 +1842,17 @@ config UACCESS_WITH_MEMCPY > > However, if the CPU data cache is using a write-allocate mode, > > this option is unlikely to provide any performance gain. > > > > +config EARLY_IOREMAP > > + depends on MMU > > + bool "Provide early_ioremap() support for kernel initialization." > > Please drop the full stop. > > > + select GENERIC_EARLY_IOREMAP > > + help > > + Provide a mechanism for kernel initialisation code to temporarily > > + map, in a highmem-agnostic way, memory pages in before ioremap() > > + and friends are available (before paging_init() has run). It uses > > + the same virtual memory range as kmap so all early mappings must > > + be unapped before paging_init() is called. > > s/unapped/unmapped/ > Will do. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/