Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757979AbaAJVJp (ORCPT ); Fri, 10 Jan 2014 16:09:45 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18029 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbaAJVJn (ORCPT ); Fri, 10 Jan 2014 16:09:43 -0500 To: "Nicholas A. Bellinger" Cc: target-devel , linux-scsi , linux-kernel , "Martin K. Petersen" , Christoph Hellwig , Hannes Reinecke , Sagi Grimberg , Or Gerlitz , Nicholas Bellinger Subject: Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD From: "Martin K. Petersen" Organization: Oracle Corporation References: <1389212157-14540-1-git-send-email-nab@daterainc.com> <1389212157-14540-15-git-send-email-nab@daterainc.com> Date: Fri, 10 Jan 2014 16:09:26 -0500 In-Reply-To: <1389212157-14540-15-git-send-email-nab@daterainc.com> (Nicholas A. Bellinger's message of "Wed, 8 Jan 2014 20:15:57 +0000") Message-ID: User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "nab" == Nicholas A Bellinger writes: nab> This patch updates tcm_loop_driver_probe() to set protection nab> information using scsi_host_set_prot() and scsi_host_set_guard(), nab> which currently enabled all modes of DIF/DIX protection, minus DIF nab> TYPE0. ITYM, DIX Type 0. And ideally you'd have a way to choose between IP and T10 CRC for the guard type. Otherwise OK. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/