Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758070AbaAJVye (ORCPT ); Fri, 10 Jan 2014 16:54:34 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:36095 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbaAJVyb (ORCPT ); Fri, 10 Jan 2014 16:54:31 -0500 Message-ID: <52D06C0C.9020300@canonical.com> Date: Fri, 10 Jan 2014 16:54:20 -0500 From: Joseph Salisbury User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Yinghai Lu CC: Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio References: <1386546869-31900-1-git-send-email-yinghai@kernel.org> <1386546869-31900-3-git-send-email-yinghai@kernel.org> <52A8BAC5.70006@canonical.com> <52D01D82.5070202@canonical.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2014 12:13 PM, Yinghai Lu wrote: > On Fri, Jan 10, 2014 at 8:19 AM, Joseph Salisbury > wrote: >> On 12/11/2013 02:55 PM, Yinghai Lu wrote: >>> On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury >>> wrote: >>>> On 12/09/2013 03:10 PM, Yinghai Lu wrote: >>>>> On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: >>>>>> That doesn't answer my question at all. >>>>>> >>>>>> I understand that this change makes it so Joseph doesn't have to use >>>>>> "pci=realloc=off". But why should auto-reallocation be limited to >>>>>> buses that have resources above 4GB? That doesn't make any sense. >>>>>> >>>>>> We should fix the reallocation code so it can deal with this case. If >>>>>> there's not enough space for everything, obviously we have to leave >>>>>> something unassigned. A ROM BAR is a good candidate for leaving >>>>>> unassigned, because most of the time we can get along without it. >>>>> Yes, that is ideal and not that simple. >>>>> but that would be hard to backport to old kernels. >>>>> >>>>> BTW, Joseph, can you try >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git >>>>> for-pci-3.14 >>>>> with pci=realloc=on >>>>> >>>>> on that system? >>>>> >>>>> Thanks >>>>> >>>>> Yinghai >>>> I noticed there was some back and forth on this thread. Do you still >>>> want me to test this version, Yinghai? >>> Yes, if that works, we would not need to put the patch in upstream for limiting >>> realloc auto scope. >>> >> Another user has confirmed that at test kernel from your branch[0] does >> resolve the bug. > Hi, Joe, > > Bjorn does not want to limit auto realloc, so this patch can not make > to upstream at this point. > > so we may have to ask user to append "pci=realloc=off" before we find > more smart way to realloc > resource. > > Thanks > > Yinghai Hi Yinghai, In a prior email you mentioned: "Yes, if that works, we would not need to put the patch in upstream for limiting realloc auto scope." Is the git tree at git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git somehow different now? Thanks, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/