Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbaAKQNv (ORCPT ); Sat, 11 Jan 2014 11:13:51 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:34248 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751241AbaAKQNt (ORCPT ); Sat, 11 Jan 2014 11:13:49 -0500 Date: Sat, 11 Jan 2014 16:13:42 +0000 From: Russell King - ARM Linux To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: lkml , linux-arm-kernel@lists.infradead.org, Linus Torvalds Subject: Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks. Message-ID: <20140111161342.GM15937@n2100.arm.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 06, 2014 at 08:33:15PM +0100, Krzysztof Hałasa wrote: > Russell et al., > > anything wrong with this fix? Well, I don't understand why moving this code around fixes a problem. After all, if PCI is enabled, then presumably common-pci.c will always be built and run - it has to be for the PCI bus to be probed. Oh, are you trying to use the platform notify callback to set the DMA mask on statically defined platform devices? No, don't do that, initialise it in the declarations instead. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/