Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751238AbaALDgG (ORCPT ); Sat, 11 Jan 2014 22:36:06 -0500 Received: from mail-qe0-f47.google.com ([209.85.128.47]:54853 "EHLO mail-qe0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbaALDgE (ORCPT ); Sat, 11 Jan 2014 22:36:04 -0500 Date: Sat, 11 Jan 2014 22:35:59 -0500 From: Tejun Heo To: Kent Overstreet Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] percpu-refcount: Add a WARN() for ref going negative Message-ID: <20140112033559.GB7874@mtj.dyndns.org> References: <1389042806-23967-1-git-send-email-kmo@daterainc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389042806-23967-1-git-send-email-kmo@daterainc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 06, 2014 at 01:13:26PM -0800, Kent Overstreet wrote: > AIO had a missing get, which led to an ioctx leak - after percpu_ref_kill() the > ref was 0 so percpu_ref_put() never saw it hit 0. > > This wasn't noticed at the time because it all happened completely silently, > this adds a WARN() which would've caught the aio bug. > > Signed-off-by: Kent Overstreet > Cc: Tejun Heo Applied to percpu/for-3.14 w/ WARN_ONCE() instead WARN(). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/