Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbaALMXn (ORCPT ); Sun, 12 Jan 2014 07:23:43 -0500 Received: from mail-ea0-f173.google.com ([209.85.215.173]:44663 "EHLO mail-ea0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbaALMXj (ORCPT ); Sun, 12 Jan 2014 07:23:39 -0500 Message-ID: <52D28946.3000202@dev.mellanox.co.il> Date: Sun, 12 Jan 2014 14:23:34 +0200 From: Sagi Grimberg User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "Martin K. Petersen" , Sagi Grimberg CC: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Christoph Hellwig , Hannes Reinecke , Or Gerlitz , Nicholas Bellinger , Oren Duer Subject: Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw References: <1389212157-14540-1-git-send-email-nab@daterainc.com> <1389212157-14540-14-git-send-email-nab@daterainc.com> <52CE7ABA.9080403@mellanox.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/10/2014 11:06 PM, Martin K. Petersen wrote: >>>>>> "Sagi" == Sagi Grimberg writes: > Sagi> I wander how we can skip sbc_dif_verify_xxxx if the transport > Sagi> already offloaded DIF verify. I think that the transport should > Sagi> signal the core layer that it is able to offload DIF > Sagi> (ADD/STRIP/PASS/VERIFY), in which case the core should turn off > Sagi> the backstore DIF verify emulation to sustain performance. > > Yeah, for SAS and FC it would be nice to leverage DIX and let the ASIC > do the actual checking and splitting. I assume the same is true for your > hw. > Correct! we should avoid a duplicate DIF processing. if the HW supports offloading DIF processing, target core can shutdown backstore verfy_read/verify_write methods. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/