Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbaAMBYc (ORCPT ); Sun, 12 Jan 2014 20:24:32 -0500 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:64077 "EHLO LGEMRELSE6Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbaAMBY2 (ORCPT ); Sun, 12 Jan 2014 20:24:28 -0500 X-AuditID: 9c930179-b7c5fae000006619-dd-52d3404acaae Date: Mon, 13 Jan 2014 10:25:06 +0900 From: Minchan Kim To: Johannes Weiner Cc: Andrew Morton , Andi Kleen , Andrea Arcangeli , Bob Liu , Christoph Hellwig , Dave Chinner , Greg Thelen , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Luigi Semenzato , Mel Gorman , Metin Doslu , Michel Lespinasse , Ozgun Erdogan , Peter Zijlstra , Rik van Riel , Roman Gushchin , Ryan Mallon , Tejun Heo , Vlastimil Babka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 4/9] mm: filemap: move radix tree hole searching here Message-ID: <20140113012506.GN1992@bbox> References: <1389377443-11755-1-git-send-email-hannes@cmpxchg.org> <1389377443-11755-5-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389377443-11755-5-git-send-email-hannes@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2014 at 01:10:38PM -0500, Johannes Weiner wrote: > The radix tree hole searching code is only used for page cache, for > example the readahead code trying to get a a picture of the area > surrounding a fault. > > It sufficed to rely on the radix tree definition of holes, which is > "empty tree slot". But this is about to change, though, as shadow > page descriptors will be stored in the page cache after the actual > pages get evicted from memory. > > Move the functions over to mm/filemap.c and make them native page > cache operations, where they can later be adapted to handle the new > definition of "page cache hole". > > Signed-off-by: Johannes Weiner Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/