Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbaAMJbD (ORCPT ); Mon, 13 Jan 2014 04:31:03 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:55693 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbaAMJbA (ORCPT ); Mon, 13 Jan 2014 04:31:00 -0500 Message-ID: <1389605449.1585.9.camel@localhost.localdomain> Subject: Re: [PATCH 02/13] ppc/cell: use get_unused_fd_flags(0) instead of get_unused_fd() From: Yann Droneaud To: Benjamin Herrenschmidt Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, cbe-oss-dev@lists.ozlabs.org Date: Mon, 13 Jan 2014 10:30:49 +0100 In-Reply-To: <1389567961.4672.111.camel@pasglop> References: <72f6f9ae898a664033f6b958bc7976b994544963.1372777600.git.ydroneaud@opteya.com> <1389567961.4672.111.camel@pasglop> Organization: OPTEYA Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.3 (3.10.3-1.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, Le lundi 13 janvier 2014 à 10:06 +1100, Benjamin Herrenschmidt a écrit : > On Tue, 2013-07-02 at 18:39 +0200, Yann Droneaud wrote: > > Macro get_unused_fd() is used to allocate a file descriptor with > > default flags. Those default flags (0) can be "unsafe": > > O_CLOEXEC must be used by default to not leak file descriptor > > across exec(). > > > > Instead of macro get_unused_fd(), functions anon_inode_getfd() > > or get_unused_fd_flags() should be used with flags given by userspace. > > If not possible, flags should be set to O_CLOEXEC to provide userspace > > with a default safe behavor. > > > > In a further patch, get_unused_fd() will be removed so that > > new code start using anon_inode_getfd() or get_unused_fd_flags() > > with correct flags. > > > > This patch replaces calls to get_unused_fd() with equivalent call to > > get_unused_fd_flags(0) to preserve current behavor for existing code. > > > > The hard coded flag value (0) should be reviewed on a per-subsystem basis, > > and, if possible, set to O_CLOEXEC. > > > > Signed-off-by: Yann Droneaud > > Should I merge this (v5 on patchwork) or let Al do it ? > Please merge it directly: patches from the previous patchsets were picked individually by each subsystem maintainer after proper review regarding setting close on exec flag by default. > Acked-by: Benjamin Herrenschmidt > Thanks a lot. > > --- > > arch/powerpc/platforms/cell/spufs/inode.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c > > index f390042..88df441 100644 > > --- a/arch/powerpc/platforms/cell/spufs/inode.c > > +++ b/arch/powerpc/platforms/cell/spufs/inode.c > > @@ -301,7 +301,7 @@ static int spufs_context_open(struct path *path) > > int ret; > > struct file *filp; > > > > - ret = get_unused_fd(); > > + ret = get_unused_fd_flags(0); > > if (ret < 0) > > return ret; > > > > @@ -518,7 +518,7 @@ static int spufs_gang_open(struct path *path) > > int ret; > > struct file *filp; > > > > - ret = get_unused_fd(); > > + ret = get_unused_fd_flags(0); > > if (ret < 0) > > return ret; > > > > Note: latest patch (from v5 patchset) is at http://lkml.kernel.org/r/fe27abcfab5563d36a3e5e58ff36e5500c39be6a.1388952061.git.ydroneaud@opteya.com v5 patchset is at http://lkml.kernel.org/r/cover.1388952061.git.ydroneaud@opteya.com Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/