Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbaAMLOf (ORCPT ); Mon, 13 Jan 2014 06:14:35 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:46450 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbaAMLOe (ORCPT ); Mon, 13 Jan 2014 06:14:34 -0500 Date: Mon, 13 Jan 2014 11:14:31 +0000 From: Charles Keepax To: Daniel Matuschek Cc: alsa-devel@alsa-project.org, Dimitris.Papastamos@wolfsonmicro.com, tiwai@suse.de, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com, perex@perex.cz, broonie@kernel.org, info@crazy-audio.com Subject: Re: [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation Message-ID: <20140113111431.GA26419@opensource.wolfsonmicro.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 12, 2014 at 10:11:25PM +0100, Daniel Matuschek wrote: > Signed-off-by: Daniel Matuschek > > After some discussions of the patch last week, here is a new version. > Simply reducing the post_table did not work, as for some frequencies > both settings (MCLKDIV=0 and MCLKDIV=1) are needed (e.g. 96 and 192kHz) > > > WM8804 can run with PLL frequencies of 256xfs and 128xfs for > most sample rates. At 192kHz only 128xfs is supported. The > existing driver selects 128xfs automatically for some lower > samples rates. By using an additional mclk_div divider, is > is now possible to control the behaviour. This allows using > 256xfs PLL frequency on all sample rates up to 96kHz. It > should allow lower jitter and better signal quality. The > behavior has to be controlled by the sound card driver, > because some sample frequency share the same setting. e.g. > 192kHz and 96kHz use 24.576MHz master clock. The only > difference is the MCLK divider. > Commit message still needs fixed up, as per Mark's comments on your last patch. Otherwise looks ok to me. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/