Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbaAMLcj (ORCPT ); Mon, 13 Jan 2014 06:32:39 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:64872 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751101AbaAMLcf (ORCPT ); Mon, 13 Jan 2014 06:32:35 -0500 From: "Rafael J. Wysocki" To: Takashi Iwai Cc: Len Brown , Oliver Neukum , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] ACPI: Blacklist Win8 OSI for some HP laptop 2013 models Date: Mon, 13 Jan 2014 12:46:31 +0100 Message-ID: <1935658.J9tLa335qc@vostro.rjw.lan> User-Agent: KMail/4.11.3 (Linux/3.13.0-rc8+; KDE/4.11.3; x86_64; ; ) In-Reply-To: <1389611658-19424-1-git-send-email-tiwai@suse.de> References: <1389611658-19424-1-git-send-email-tiwai@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, January 13, 2014 12:14:18 PM Takashi Iwai wrote: > The BIOS on recent HP laptops behaves differently with Win8 OSI, > e.g. no backlight control and no rfkill are available. List them in > the blacklist as a workaround. > > This patch tries to reduce the added items by matching "G1" suffix, > e.g. machines are named like "HP ProBook 430 G1". > > Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=856294 > Signed-off-by: Takashi Iwai > --- > > Rafael, could you check this? > If the problem were only about the backlight, we could fix differenly, > but BIOS on these machines seems to switching more other functions > like rfkill. It looks like I have this patch in my linux-next branch. Thanks! > drivers/acpi/blacklist.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > index 078c4f7fe2dd..40c91f5052ef 100644 > --- a/drivers/acpi/blacklist.c > +++ b/drivers/acpi/blacklist.c > @@ -323,6 +323,56 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"), > }, > }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP ProBook 2013 models", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "), > + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP EliteBook 2013 models", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "), > + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP ZBook 14", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP ZBook 15", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP ZBook 17", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP EliteBook 8780w", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"), > + }, > + }, > > /* > * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/