Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbaAMLdb (ORCPT ); Mon, 13 Jan 2014 06:33:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58420 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbaAMLd1 (ORCPT ); Mon, 13 Jan 2014 06:33:27 -0500 Date: Mon, 13 Jan 2014 12:33:26 +0100 Message-ID: From: Takashi Iwai To: "Rafael J. Wysocki" Cc: Len Brown , Oliver Neukum , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] ACPI: Blacklist Win8 OSI for some HP laptop 2013 models In-Reply-To: <1935658.J9tLa335qc@vostro.rjw.lan> References: <1389611658-19424-1-git-send-email-tiwai@suse.de> <1935658.J9tLa335qc@vostro.rjw.lan> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 13 Jan 2014 12:46:31 +0100, Rafael J. Wysocki wrote: > > On Monday, January 13, 2014 12:14:18 PM Takashi Iwai wrote: > > The BIOS on recent HP laptops behaves differently with Win8 OSI, > > e.g. no backlight control and no rfkill are available. List them in > > the blacklist as a workaround. > > > > This patch tries to reduce the added items by matching "G1" suffix, > > e.g. machines are named like "HP ProBook 430 G1". > > > > Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=856294 > > Signed-off-by: Takashi Iwai > > --- > > > > Rafael, could you check this? > > If the problem were only about the backlight, we could fix differenly, > > but BIOS on these machines seems to switching more other functions > > like rfkill. > > It looks like I have this patch in my linux-next branch. OK, thanks! Takashi > > Thanks! > > > > drivers/acpi/blacklist.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > > index 078c4f7fe2dd..40c91f5052ef 100644 > > --- a/drivers/acpi/blacklist.c > > +++ b/drivers/acpi/blacklist.c > > @@ -323,6 +323,56 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > > DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"), > > }, > > }, > > + { > > + .callback = dmi_disable_osi_win8, > > + .ident = "HP ProBook 2013 models", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "), > > + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), > > + }, > > + }, > > + { > > + .callback = dmi_disable_osi_win8, > > + .ident = "HP EliteBook 2013 models", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "), > > + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), > > + }, > > + }, > > + { > > + .callback = dmi_disable_osi_win8, > > + .ident = "HP ZBook 14", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"), > > + }, > > + }, > > + { > > + .callback = dmi_disable_osi_win8, > > + .ident = "HP ZBook 15", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"), > > + }, > > + }, > > + { > > + .callback = dmi_disable_osi_win8, > > + .ident = "HP ZBook 17", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"), > > + }, > > + }, > > + { > > + .callback = dmi_disable_osi_win8, > > + .ident = "HP EliteBook 8780w", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"), > > + }, > > + }, > > > > /* > > * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/