Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbaAMS3N (ORCPT ); Mon, 13 Jan 2014 13:29:13 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:39149 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbaAMS3K (ORCPT ); Mon, 13 Jan 2014 13:29:10 -0500 Message-ID: <1389637859.5567.431.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 09/14] target/configfs: Expose protection device attributes From: "Nicholas A. Bellinger" To: "Martin K. Petersen" Cc: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Christoph Hellwig , Hannes Reinecke , Sagi Grimberg , Or Gerlitz Date: Mon, 13 Jan 2014 10:30:59 -0800 In-Reply-To: References: <1389212157-14540-1-git-send-email-nab@daterainc.com> <1389212157-14540-10-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey MKP, On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > nab> This patch adds support for exposing DIF protection device > nab> attributes via configfs. This includes: > > nab> pi_prot_type: Protection Type (0, 1, 3 currently support) > nab> pi_prot_version: Protection Version (DIF v1 currently supported) > > What's DIF v2? > This would be the proposed 16-byte protection scheme for SBC4. > nab> pi_guard_type: Guard Type (1=DIF CRC, 2=IP CRC) > > The IP checksum is only supported by DIX between OS and initiator, not > by the target. I guess we could signal to the initiator via a > vendor-private VPD that IP checksum is supported directly. But now what > we have hardware-accelerated T10 CRC I don't think it's a big deal. > > (scsi_debug supports IP checksum because it's both initiator and > target). > In that case, dropping the IP checksum related code now.. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/