Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751677AbaAMSnX (ORCPT ); Mon, 13 Jan 2014 13:43:23 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:48137 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbaAMSnV (ORCPT ); Mon, 13 Jan 2014 13:43:21 -0500 Message-ID: <1389638711.5567.437.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD From: "Nicholas A. Bellinger" To: "Martin K. Petersen" Cc: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Christoph Hellwig , Hannes Reinecke , Sagi Grimberg , Or Gerlitz Date: Mon, 13 Jan 2014 10:45:11 -0800 In-Reply-To: References: <1389212157-14540-1-git-send-email-nab@daterainc.com> <1389212157-14540-15-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-01-10 at 16:09 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > nab> This patch updates tcm_loop_driver_probe() to set protection > nab> information using scsi_host_set_prot() and scsi_host_set_guard(), > nab> which currently enabled all modes of DIF/DIX protection, minus DIF > nab> TYPE0. > > ITYM, DIX Type 0. Yes. Fixed up the commit message. > And ideally you'd have a way to choose between IP and > T10 CRC for the guard type. > Sure, this can be exposed at a tcm_loop configfs attribute that is accessible after scsi_add_host() has been called, which I assume is OK to do.. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/