Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbaAMSuV (ORCPT ); Mon, 13 Jan 2014 13:50:21 -0500 Received: from mail-oa0-f54.google.com ([209.85.219.54]:36222 "EHLO mail-oa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbaAMSuK (ORCPT ); Mon, 13 Jan 2014 13:50:10 -0500 MIME-Version: 1.0 In-Reply-To: <20140113123126.20574.74329.stgit@patser> References: <20140113122818.20574.34710.stgit@patser> <20140113123126.20574.74329.stgit@patser> Date: Mon, 13 Jan 2014 10:50:09 -0800 Message-ID: Subject: Re: [PATCH 1/7] sched: allow try_to_wake_up to be used internally outside of core.c From: Colin Cross To: Maarten Lankhorst Cc: lkml , "open list:GENERIC INCLUDE/A..." , "linaro-mm-sig@lists.linaro.org" , robdclark@gmail.com, "dri-devel@lists.freedesktop.org" , daniel@ffwll.ch, Sumit Semwal , linux-media@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 13, 2014 at 4:31 AM, Maarten Lankhorst wrote: > The kernel fence implementation doesn't use event queues, but needs > to perform the same wake up. The symbol is not exported, since the > fence implementation is not built as a module. > > Signed-off-by: Maarten Lankhorst > --- > include/linux/wait.h | 1 + > kernel/sched/core.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/wait.h b/include/linux/wait.h > index eaa00b10abaa..c54e3ef50134 100644 > --- a/include/linux/wait.h > +++ b/include/linux/wait.h > @@ -12,6 +12,7 @@ > typedef struct __wait_queue wait_queue_t; > typedef int (*wait_queue_func_t)(wait_queue_t *wait, unsigned mode, int flags, void *key); > int default_wake_function(wait_queue_t *wait, unsigned mode, int flags, void *key); > +int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags); > > struct __wait_queue { > unsigned int flags; > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index a88f4a485c5e..f41d317042dd 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1578,7 +1578,7 @@ static void ttwu_queue(struct task_struct *p, int cpu) > * Return: %true if @p was woken up, %false if it was already running. > * or @state didn't match @p's state. > */ > -static int > +int > try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) > { > unsigned long flags; > wake_up_state is already available in linux/sched.h, can you use that? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/