Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752573AbaAMTVP (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jan 2014 14:21:15 -0500
Received: from mail.linux-iscsi.org ([67.23.28.174]:50684 "EHLO
	linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751725AbaAMTVL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jan 2014 14:21:11 -0500
Message-ID: <1389640982.5567.442.camel@haakon3.risingtidesystems.com>
Subject: Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update
 sbc_parse_cdb for DIF
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Sagi Grimberg <sagig@mellanox.com>,
        "Nicholas A. Bellinger" <nab@daterainc.com>,
        target-devel <target-devel@vger.kernel.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
        Or Gerlitz <ogerlitz@mellanox.com>, oren Duer <oren@mellanox.com>
Date: Mon, 13 Jan 2014 11:23:02 -0800
In-Reply-To: <52D283B8.6050108@dev.mellanox.co.il>
References: <1389212157-14540-1-git-send-email-nab@daterainc.com>
	 <1389212157-14540-4-git-send-email-nab@daterainc.com>
	 <52CEB901.6030504@mellanox.com>
	 <1389337456.5567.412.camel@haakon3.risingtidesystems.com>
	 <52D283B8.6050108@dev.mellanox.co.il>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.4.4-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2014-01-12 at 13:59 +0200, Sagi Grimberg wrote:
> On 1/10/2014 9:04 AM, Nicholas A. Bellinger wrote:
> > On Thu, 2014-01-09 at 16:58 +0200, Sagi Grimberg wrote:
> >> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:

<SNIP>

> >>> diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
> >>> index 52ae54e..600ffcb 100644
> >>> --- a/drivers/target/target_core_sbc.c
> >>> +++ b/drivers/target/target_core_sbc.c
> >>> @@ -563,6 +563,27 @@ sbc_compare_and_write(struct se_cmd *cmd)
> >>>    	return TCM_NO_SENSE;
> >>>    }
> >>>    
> >>> +bool
> >>> +sbc_check_prot(struct se_device *dev, struct se_cmd *cmd, unsigned char *cdb)
> >>> +{
> >>> +	if (!dev->dev_attrib.pi_prot_type)
> >>> +		return true;
> >>> +
> >>> +	if (dev->dev_attrib.pi_prot_type == TARGET_DIF_TYPE2_PROT &&
> >>> +	   (cdb[1] & 0xe0))
> >>> +		return false;
> >>> +
> >>> +	if (!(cdb[1] & 0xe0)) {
> >>> +		pr_warn("Target: Unprotected READ/WRITE to DIF device\n");
> >>> +		return true;
> >>> +	}
> >>> +	if (!cmd->t_prot_sg || !cmd->t_prot_nents)
> >>> +		return true;
> >>> +
> >>> +	cmd->se_cmd_flags |= SCF_PROT;
> >> Isn't this the place to fill the se_cmd DIF execution parameters?
> >> prot_op, prot_type, guard_type, initial_reftag, apptag etc...
> >> Next, all parties interested in DIF execution should look in se_cmd
> >> (backstore, transport).
> > Yes, working on this for -v2 as well.  :)
> 
> OK, so just to be clear, both the transport and the backstore will be 
> look in se_cmd protection attributes when executing IO correct?
> 

Correct.

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/