Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbaAMWiY (ORCPT ); Mon, 13 Jan 2014 17:38:24 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19927 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbaAMWiW (ORCPT ); Mon, 13 Jan 2014 17:38:22 -0500 Date: Tue, 14 Jan 2014 01:38:04 +0300 From: Dan Carpenter To: Pol Eyschen Cc: devel@driverdev.osuosl.org, jack@suse.cz, sachin.kamat@linaro.org, linux-kernel@vger.kernel.org, ufimtseva@gmail.com, gregkh@linuxfoundation.org Subject: Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c Message-ID: <20140113223804.GI7444@mwanda> References: <1389642100-3601-1-git-send-email-poleyschen@gmail.com> <20140113213552.GA5368@einon.net> <20140113214429.GH7444@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 13, 2014 at 11:31:29PM +0100, Pol Eyschen wrote: > > > I took the original comments that were there, and just formatted them > to be in order with the coding style, I didn't add or remove > anything. This is my first patch so I didn't want to mess too much > with what was there before, even if the comments sometimes seemed > superfluous to me. No problem, everyone's first patch is rejected. Just fix it up in line with the review comments and resend. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/