Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbaANBgq (ORCPT ); Mon, 13 Jan 2014 20:36:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28939 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbaANBgp (ORCPT ); Mon, 13 Jan 2014 20:36:45 -0500 Date: Tue, 14 Jan 2014 09:36:51 +0800 From: Dave Young To: Matt Fleming Cc: Borislav Petkov , Linux EFI , LKML , Borislav Petkov , Matthew Garrett , "H. Peter Anvin" , Toshi Kani Subject: Re: [PATCH 2/4] efi: Dump the EFI page table Message-ID: <20140114013651.GA4327@dhcp-16-126.nay.redhat.com> References: <1389473370-1940-1-git-send-email-bp@alien8.de> <1389473370-1940-3-git-send-email-bp@alien8.de> <20140113160018.GJ3256@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140113160018.GJ3256@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/14 at 04:00pm, Matt Fleming wrote: > On Sat, 11 Jan, at 09:49:28PM, Borislav Petkov wrote: > > From: Borislav Petkov > > > > This is very useful for debugging issues with the recently added > > pagetable switching code for EFI virtual mode. > > > > Signed-off-by: Borislav Petkov > > --- > > arch/x86/platform/efi/efi.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > > index d62ec87a2b26..c34be4ce94c9 100644 > > --- a/arch/x86/platform/efi/efi.c > > +++ b/arch/x86/platform/efi/efi.c > > @@ -54,6 +54,7 @@ > > #include > > > > #define EFI_DEBUG > > +#undef EFI_PGT_DBG > > Should this be a Kconfig option? Hacking source files to enable debug > isn't the best idea. Plus you could make it depend on X86_PTDUMP. I have same feeling, either a new Kconfig option or just print it while ptdump_to_dmesg is true by default without extra Kconfig. Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/