Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbaANBkB (ORCPT ); Mon, 13 Jan 2014 20:40:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49583 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbaANBjz (ORCPT ); Mon, 13 Jan 2014 20:39:55 -0500 Date: Tue, 14 Jan 2014 09:40:03 +0800 From: Dave Young To: Arjan van de Ven Cc: Borislav Petkov , Linux EFI , LKML , Borislav Petkov , Matt Fleming , Matthew Garrett , "H. Peter Anvin" , Toshi Kani Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable Message-ID: <20140114014003.GB4327@dhcp-16-126.nay.redhat.com> References: <1389473370-1940-1-git-send-email-bp@alien8.de> <1389473370-1940-2-git-send-email-bp@alien8.de> <20140113053240.GA11237@dhcp-16-126.nay.redhat.com> <20140113101822.GA5388@pd.tnic> <20140113122320.GA1900@darkstar.nay.redhat.com> <52D3FCAA.7070004@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52D3FCAA.7070004@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/14 at 06:48am, Arjan van de Ven wrote: > On 1/13/2014 4:23 AM, Dave Young wrote: > >> > >>>How about do not limit to only if (pgd) case, instead do something > >>>like below: set dump_to_dmesg as a module parameter > >> > >>X86_PTDUMP is not a module. > > > >Hmm, I just see the module macros in the code, since it's a bool Kconfig > >I think the dump_pagetables.c need a cleanup, > >remove the #include and below lines: > >MODULE_LICENSE("GPL"); > >MODULE_AUTHOR("Arjan van de Ven "); > >MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables"); > > personally I consider it good form to always have this kind of information in .c files, > regardless of the KConfig side of thing... I agree it's good to add these infomation, but they can be added in comment. IMHO it will be better in that way. Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/