Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbaANG75 (ORCPT ); Tue, 14 Jan 2014 01:59:57 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:60656 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbaANG7x (ORCPT ); Tue, 14 Jan 2014 01:59:53 -0500 Date: Mon, 13 Jan 2014 22:59:52 -0800 (PST) Message-ID: <871u0bgiai.wl%kuninori.morimoto.gx@gmail.com> From: Kuninori Morimoto To: Xiubo Li Cc: , , , , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data In-Reply-To: <1389678282-1097-1-git-send-email-Li.Xiubo@freescale.com> References: <1389678282-1097-1-git-send-email-Li.Xiubo@freescale.com> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiubo Thank you for your patch > Whether the dt is used or not, almost all the simple card information > for the DAI link and sound card are initialized in the simple card driver. > > And for the platform caller, the snd_link and snd_card are of no use, so > move them from struct asoc_simple_card_info to struct asoc_simple_card_data. > > And now only one DAI link is supported for simple card. > > Suggested-by: Jean-Francois Moine > Signed-off-by: Xiubo Li > --- This patch seems have many this kind of lines - info->xxx + sdata->info->xxx But, how about add this line to each function ? struct asoc_simple_card_info *info = &sdata->info; Patch will be more readable Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/