From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
CC: "broonie@kernel.org" <broonie@kernel.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "moinejf@free.fr" <moinejf@free.fr>,
        "kuninori.morimoto.gx@renesas.com" <kuninori.morimoto.gx@renesas.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add
	asoc_simple_card_data for the simple card driver data
Thread-Topic: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add
	asoc_simple_card_data for the simple card driver data
Thread-Index: AQHPEPZQHcGE1bEqj0q1mNvuGMgzF5qD2O6A
Date: Tue, 14 Jan 2014 07:56:32 +0000
Message-ID: <96cb876ff05c4062ab5a2c92fb7b3c41@BY2PR03MB505.namprd03.prod.outlook.com>
References: <1389678282-1097-1-git-send-email-Li.Xiubo@freescale.com>
 <871u0bgiai.wl%kuninori.morimoto.gx@gmail.com>
In-Reply-To: <871u0bgiai.wl%kuninori.morimoto.gx@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org


> > Whether the dt is used or not, almost all the simple card information
> > for the DAI link and sound card are initialized in the simple card driver.
> >
> > And for the platform caller, the snd_link and snd_card are of no use, so
> > move them from struct asoc_simple_card_info to struct asoc_simple_card_data.
> >
> > And now only one DAI link is supported for simple card.
> >
> > Suggested-by: Jean-Francois Moine <moinejf@free.fr>
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> 
> This patch seems have many this kind of lines
>   -	info->xxx
>   +	sdata->info->xxx
> 
> But, how about add this line to each function ?
> 
>      struct asoc_simple_card_info *info = &sdata->info;
> 
> Patch will be more readable
>

Yes, that's looks perfect.

See the next version please.

Thanks,

--
Best Regards,
Xiubo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/