Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbaANLOc (ORCPT ); Tue, 14 Jan 2014 06:14:32 -0500 Received: from mail-bk0-f47.google.com ([209.85.214.47]:50159 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbaANLO3 (ORCPT ); Tue, 14 Jan 2014 06:14:29 -0500 MIME-Version: 1.0 In-Reply-To: <52D404DE.2020806@ti.com> References: <1389625399-24087-1-git-send-email-taras.kondratiuk@linaro.org> <52D404DE.2020806@ti.com> Date: Tue, 14 Jan 2014 13:14:28 +0200 Message-ID: Subject: Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian From: Taras Kondratiuk To: Nishanth Menon Cc: Tero Kristo , Patch Tracking , Linaro Networking , Linaro Kernel , Victor Kamensky , Tony Lindgren , Russell King , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , open list Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13 January 2014 17:23, Nishanth Menon wrote: > On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: >> From: Victor Kamensky >> >> Assembler functions defined in sleep44xx.S need to byteswap values >> after read / before write from h/w register if code compiled in big >> endian mode. Simple change to do 'rev x, x' before str instruction >> and after ldr instruction that deals with h/w registers. >> >> Signed-off-by: Victor Kamensky >> Signed-off-by: Taras Kondratiuk >> --- >> This is a part of RFC series [1]. >> Based on v3.13-rc8. >> >> [1] http://www.spinics.net/lists/linux-omap/msg99927.html >> >> arch/arm/mach-omap2/sleep44xx.S | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> > > OMAP4 is LE, and if there is a gcc flag for the same, is'nt it cleaner > to deal with it in Makefile rather than trying to make an assembly > meant only for LE by force building it for BE? Hi Nishanth I'm not sure I got your point. Do you propose to build this file as LE while the rest of kernel is BE? -- Regards, Taras Kondratiuk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/