Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751592AbaANPQI (ORCPT ); Tue, 14 Jan 2014 10:16:08 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56558 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbaANPQF (ORCPT ); Tue, 14 Jan 2014 10:16:05 -0500 Date: Tue, 14 Jan 2014 16:16:03 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Andrew Veliath , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH, RFC 23/30] oss: msnd_pinnacle: avoid interruptible_sleep_on_timeout In-Reply-To: <1388664474-1710039-24-git-send-email-arnd@arndb.de> References: <1388664474-1710039-1-git-send-email-arnd@arndb.de> <1388664474-1710039-24-git-send-email-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 2 Jan 2014 13:07:47 +0100, Arnd Bergmann wrote: > > We want to remove all sleep_on variants from the kernel because they are > racy. In case of the pinnacle driver, we can replace > interruptible_sleep_on_timeout with wait_event_interruptible_timeout > by changing the meaning of a few flags used in the driver so they > are cleared at wakeup time, which is a somewhat more appropriate > way to do the same, although probably still racy. > > Signed-off-by: Arnd Bergmann > Cc: Andrew Veliath > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-devel@alsa-project.org I applied all 5 patches (23, 25, 24, 26, and 27) for sound/oss/*, some with trivial space fixes. Thanks! Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/