Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbaANPZ1 (ORCPT ); Tue, 14 Jan 2014 10:25:27 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:56044 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbaANPZY (ORCPT ); Tue, 14 Jan 2014 10:25:24 -0500 MIME-Version: 1.0 In-Reply-To: <201401141426.16497.arnd@arndb.de> References: <1389445524-30623-1-git-send-email-leif.lindholm@linaro.org> <201401140752.33257.arnd@arndb.de> <20140114114419.GH30907@bivouac.eciton.net> <201401141426.16497.arnd@arndb.de> Date: Tue, 14 Jan 2014 15:25:23 +0000 Message-ID: Subject: Re: [PATCH v4 4/5] arm: Add [U]EFI runtime services support From: Leif Lindholm To: Arnd Bergmann Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Grant Likely , "linux-efi@vger.kernel.org" , "linux@arm.linux.org.uk" , Patch Tracking , Will Deacon , Roy Franz , "Fleming, Matt" , Mark Salter Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14 January 2014 13:26, Arnd Bergmann wrote: >> > > Are you suggesting that I should #ifndef ARM in common code, or that I >> > > should neglect to document what the common code will do with data it is >> > > given by UEFI? >> > >> > It would probably be good to document the fact that it won't work, >> > possibly even having a BUG_ON statement in the code for this case. >> >> Why? >> >> You'll only touch that pointer if you enable CONFIG_ACPI, and if you >> do you probably want that address. Sounds a bit hostile to throw a BUG >> in the face of someone who's (for example) just succeeded to get Linux >> running on a Windows RT device. > > But we know that it can't work unless a lot of other things get changed > in the kernel. We know using ACPI cannot work without updates to the kernel. That doesn't mean we need to throw a BUG just because the firmware tells us a table exists. >> Although no other architectures supported by UEFI support big-endian, >> so to be honest, I don't want to have to be the first one to validate >> that in order to get the basic support into the kernel. > > I think there was a project to run UEFI on PowerPC on some stage, though > I can't find any code now. That does sound familiar, but there is nothing in the specification. / Leif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/