Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbaANVXK (ORCPT ); Tue, 14 Jan 2014 16:23:10 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:63873 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751492AbaANVXF (ORCPT ); Tue, 14 Jan 2014 16:23:05 -0500 From: "Rafael J. Wysocki" To: Matthew Garrett , Lan Tianyu Cc: Dmitry Torokhov , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, fcr@adinet.com.uy, l@dorileo.org Subject: Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS Date: Tue, 14 Jan 2014 22:37:02 +0100 Message-ID: <5255063.SeYbBZqxVQ@vostro.rjw.lan> User-Agent: KMail/4.11.3 (Linux/3.13.0-rc8+; KDE/4.11.3; x86_64; ; ) In-Reply-To: <20140114160601.GB4307@srcf.ucam.org> References: <1389019837-13619-1-git-send-email-tianyu.lan@intel.com> <1793775.ULjNzyMivD@vostro.rjw.lan> <20140114160601.GB4307@srcf.ucam.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: > On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: > > > Queued up as a fix for 3.13 (I fixed up the indentation). > > Ah, sorry, I missed this chunk of the thread. If the system provides > valid _BIF data then we should possibly just fall back to that rather > than adding another quirk table. The problem is to know that _BIX is broken. If we could figure that out upfront, we woulnd't need the quirk table in any case. Tianyu, can we do some effort during the driver initialization to detect this breakage and handle it without blacklisting systems? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/