Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116AbaANVYS (ORCPT ); Tue, 14 Jan 2014 16:24:18 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:36683 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbaANVYQ (ORCPT ); Tue, 14 Jan 2014 16:24:16 -0500 Date: Tue, 14 Jan 2014 21:24:06 +0000 From: Matthew Garrett To: "Rafael J. Wysocki" Cc: Lan Tianyu , Dmitry Torokhov , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, fcr@adinet.com.uy, l@dorileo.org Subject: Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS Message-ID: <20140114212406.GA25438@srcf.ucam.org> References: <1389019837-13619-1-git-send-email-tianyu.lan@intel.com> <1793775.ULjNzyMivD@vostro.rjw.lan> <20140114160601.GB4307@srcf.ucam.org> <5255063.SeYbBZqxVQ@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5255063.SeYbBZqxVQ@vostro.rjw.lan> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: > On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: > > On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: > > > > > Queued up as a fix for 3.13 (I fixed up the indentation). > > > > Ah, sorry, I missed this chunk of the thread. If the system provides > > valid _BIF data then we should possibly just fall back to that rather > > than adding another quirk table. > > The problem is to know that _BIX is broken. If we could figure that out > upfront, we woulnd't need the quirk table in any case. It's obvious that it is in this case - the package is the wrong size. -- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/