Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751837AbaAOBQL (ORCPT ); Tue, 14 Jan 2014 20:16:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9993 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbaAOBQH (ORCPT ); Tue, 14 Jan 2014 20:16:07 -0500 Date: Wed, 15 Jan 2014 09:16:09 +0800 From: Dave Young To: "H. Peter Anvin" Cc: Arjan van de Ven , Borislav Petkov , Linux EFI , LKML , Borislav Petkov , Matt Fleming , Matthew Garrett , Toshi Kani Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable Message-ID: <20140115011609.GD23767@dhcp-16-126.nay.redhat.com> References: <1389473370-1940-1-git-send-email-bp@alien8.de> <1389473370-1940-2-git-send-email-bp@alien8.de> <20140113053240.GA11237@dhcp-16-126.nay.redhat.com> <20140113101822.GA5388@pd.tnic> <20140113122320.GA1900@darkstar.nay.redhat.com> <52D3FCAA.7070004@linux.intel.com> <20140114014003.GB4327@dhcp-16-126.nay.redhat.com> <52D57F75.7060308@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52D57F75.7060308@zytor.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/14 at 10:18am, H. Peter Anvin wrote: > On 01/13/2014 05:40 PM, Dave Young wrote: > > On 01/13/14 at 06:48am, Arjan van de Ven wrote: > >> On 1/13/2014 4:23 AM, Dave Young wrote: > >>>> > >>>>> How about do not limit to only if (pgd) case, instead do something > >>>>> like below: set dump_to_dmesg as a module parameter > >>>> > >>>> X86_PTDUMP is not a module. > >>> > >>> Hmm, I just see the module macros in the code, since it's a bool Kconfig > >>> I think the dump_pagetables.c need a cleanup, > >>> remove the #include and below lines: > >>> MODULE_LICENSE("GPL"); > >>> MODULE_AUTHOR("Arjan van de Ven "); > >>> MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables"); > >> > >> personally I consider it good form to always have this kind of information in .c files, > >> regardless of the KConfig side of thing... > > > > I agree it's good to add these infomation, but they can be added in comment. > > IMHO it will be better in that way. > > > > Why the [Finnish] do you feel that information needs to be in a > different form because it is (currently!) not available as a module? I think moving them to comment can avoid including extra linux/module.h If a module specific parameter is needed maybe it's not bad to add dummy module_init/module_exit Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/