Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbaAOQVU (ORCPT ); Wed, 15 Jan 2014 11:21:20 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:14991 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751932AbaAOQVS (ORCPT ); Wed, 15 Jan 2014 11:21:18 -0500 Date: Wed, 15 Jan 2014 11:21:16 -0500 From: Steven Rostedt To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Frederic Weisbecker , Peter Zijlstra , Ingo Molnar , Namhyung Kim , LKML , Jiri Olsa Subject: Re: [PATCH 08/17] tools lib traceevent: Unregister handler when function plugin unloaded Message-ID: <20140115112116.21fe7f31@gandalf.local.home> In-Reply-To: <1389750340-15965-9-git-send-email-namhyung@kernel.org> References: <1389750340-15965-1-git-send-email-namhyung@kernel.org> <1389750340-15965-9-git-send-email-namhyung@kernel.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jan 2014 10:45:31 +0900 Namhyung Kim wrote: > The function handler should be unregistered when the plugin unloaded > otherwise it'll try to access invalid memory. > > Cc: Jiri Olsa > Signed-off-by: Namhyung Kim Acked-by: Steven Rostedt -- Steve > --- > tools/lib/traceevent/plugin_function.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/lib/traceevent/plugin_function.c b/tools/lib/traceevent/plugin_function.c > index 39461485f9a7..80ba4ff1fe84 100644 > --- a/tools/lib/traceevent/plugin_function.c > +++ b/tools/lib/traceevent/plugin_function.c > @@ -148,6 +148,9 @@ void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent) > { > int i, x; > > + pevent_unregister_event_handler(pevent, -1, "ftrace", "function", > + function_handler, NULL); > + > for (i = 0; i <= cpus; i++) { > for (x = 0; x < fstack[i].size && fstack[i].stack[x]; x++) > free(fstack[i].stack[x]); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/